Review Request 112236: krunner: Add the full name of completion matches to history

Harald Hvaal harald.hvaal at gmail.com
Sat Aug 31 10:34:26 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112236/
-----------------------------------------------------------

(Updated Aug. 31, 2013, 11:34 a.m.)


Status
------

This change has been marked as submitted.


Review request for kde-workspace and Plasma.


Description
-------

Previously you would not record the actual item you chose after choosing an auto-completion, so if you typed say "lal" and you chose a completion way down the list, the history item would not reflect that choice, only what you typed to get to the completion list.

This commit will fill the history combo box with the actual hit you executed, instead of half-complete strings that don't make sense until you actually select them.
Exact matches are added as-is.

example: type ass, and you get Qt Assistant. Instead of adding "ass" to the history, "Qt Assistant" will be added.


Diffs
-----

  krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 
  kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml 8832d1d03e47a4e6382877d18ee664ecd4d12343 

Diff: http://git.reviewboard.kde.org/r/112236/diff/


Testing
-------


Thanks,

Harald Hvaal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130831/e3fda367/attachment.htm>


More information about the kde-core-devel mailing list