Review Request 112328: Add case sensitive sorting option to KGlobalSettings and KDirSortFilterProxyModel
Eugene Shalygin
eugene.shalygin at gmail.com
Thu Aug 29 14:11:53 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112328/
-----------------------------------------------------------
Review request for Dolphin and kdelibs.
Description
-------
There are number of people who want to have case sensitive sorting in file manager and file dialogs (that would be consistent with locale settings).
The proposed patch adds a property to KGlobalSettings (caseSensitiveSorting()) and the new signal sortingModeChanged(), which deprecates naturalSortingChanged(), so the clients can connect to only one event and do not resort their models twice (maybe and option for the event to pass the change reason would be useful?).
KDirSortFilterProxyModel is changed in a trivial manner to use new event and handle case sensitivity changes.
This addresses bug https://bugs.kde.org/show_bug.cgi?id=148550.
http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=148550
Diffs
-----
kdeui/kernel/kglobalsettings.h 96da20e
kdeui/kernel/kglobalsettings.cpp 2e3a7eb
kfile/kdirsortfilterproxymodel.h 63cf04c
kfile/kdirsortfilterproxymodel.cpp 34ddcd2
Diff: http://git.reviewboard.kde.org/r/112328/diff/
Testing
-------
Manual
Thanks,
Eugene Shalygin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130829/b87f3698/attachment.htm>
More information about the kde-core-devel
mailing list