Review Request 112326: enable keystate dataengine on KF5

Sebastian Kügler sebas at kde.org
Wed Aug 28 12:52:57 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112326/#review38790
-----------------------------------------------------------



plasma/generic/dataengines/keystate/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112326/#comment28651>

    should be ${KGuiAddons_LIBRARIES}


- Sebastian Kügler


On Aug. 28, 2013, 11:51 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112326/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 11:51 a.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> Enable keystate DataEngine on KF5.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt 8b0d21b 
>   plasma/generic/dataengines/keystate/CMakeLists.txt 3f92173 
>   plasma/generic/dataengines/keystate/keystate.cpp 99bdd76 
> 
> Diff: http://git.reviewboard.kde.org/r/112326/diff/
> 
> 
> Testing
> -------
> 
> Compiles - check
> Links - check
> Installs - check
> Works - check
> 
> However somehow its not showing keyboard keys, looks like problem in kdelibs KModifierKeyInfo.
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130828/30a55bc5/attachment.htm>


More information about the kde-core-devel mailing list