Review request: kde-runtime/kwalletd branch kwalletd-gpg

[Albert Astals Cid]

Noone taking a stab at this?

Valentin do you know of someone you can annoy to ge the code reviewed?

El Dissabte, 17 d'agost de 2013, a les 14:22:35, Valentin Rusu va escriure:
> Hello,
> 
> kwalletd now supports GPG encryption. The code is fully functional, at
> least on my system, and I pushed it to the kwalletd-gpg branch of
> kde-runtime.
> See my blog post for more information:
> http://www.rusu.info/wp/?p=248
> 
> I'd like now to ask you to review the code before merging it to the
> master. And speaking about the master, I'd also like to know what would
> be the good timing to do it, as 4.11 is a long-term support version. But
> let's do things one after another and let's start with the feedback I'll
> welcome from all of you. I'm also wondering if I should I use
> reviewboard for this feature, knowing that's best to actually clone and
> run the code in order to test it, and reviewboard only let us read the code?

Well, if you give the people a way to see the diff that's awesome. How do i 
git diff your branch and master without seeing changes in master unrelated to 
your changes?

Cheers,
  Albert

> 
> Regards,