Review Request 112235: Move focus to search field upon typing from result list

Harald Hvaal harald.hvaal at gmail.com
Sat Aug 24 15:42:03 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112235/
-----------------------------------------------------------

(Updated Aug. 24, 2013, 2:42 p.m.)


Review request for kde-workspace.


Changes
-------

Although I can't say I'm impressed by how the resultlist handles the pgup/down keys, with this change they are no longer forwarded to the search input.
About up/down, that just works because it is handled in the switch just above in the same function, and never gets forwarded.


Description
-------

Upon typing after having the focus moved down to the results, the focus will be moved back to the search input immediately.


Diffs (updated)
-----

  krunner/interfaces/default/resultitem.cpp 31fe94c96195fdaeaf548207f99b294f7d768203 
  krunner/interfaces/default/resultscene.cpp 514c2c82d0fe3c3aa04200b5e254a6489bffd89d 

Diff: http://git.reviewboard.kde.org/r/112235/diff/


Testing
-------


Thanks,

Harald Hvaal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130824/30aa2004/attachment.htm>


More information about the kde-core-devel mailing list