Review Request 110042: Find Qt5 version of DBusMenuQt

Albert Astals Cid aacid at kde.org
Thu Aug 15 23:05:46 BST 2013



> On May 20, 2013, 2:08 a.m., Ian Monroe wrote:
> > Ship It!

Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110042/#review32794
-----------------------------------------------------------


On April 16, 2013, 1:26 p.m., Frederik Gladhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110042/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 1:26 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Build fix for dbusmenu qt5 changes.
> This appends the 5 to include path and lib dir in the find module.
> Also rename the whole thing to not conflict with the Qt 4 version.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 00402d4 
>   cmake/modules/FindDBusMenuQt.cmake 5af70ef 
>   cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110042/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130815/613d180b/attachment.htm>


More information about the kde-core-devel mailing list