Review Request 112099: [kcontrol/locale] update the sample when input changed

Santeri Piippo slatenails64 at gmail.com
Thu Aug 15 17:29:29 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112099/
-----------------------------------------------------------

(Updated Aug. 15, 2013, 7:29 p.m.)


Review request for KDE Runtime and Albert Astals Cid.


Changes
-------

removed filter enum


Description
-------

when the input texts are changed the sample did not update and only was updated with the 1 second timer. with applied patch it updates right away.

for performance reasons updateSample() was given a flags parameter for filtering out what to update, defaults to all, i.e. original behavior.


Diffs (updated)
-----

  kcontrol/locale/kcmlocale.cpp 62d5aef 

Diff: http://git.reviewboard.kde.org/r/112099/diff/


Testing
-------

replaced kcm_locale.so in kubuntu 13.04 with git-compiled one, works fine for me.


Thanks,

Santeri Piippo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130815/9d6d59ca/attachment.htm>


More information about the kde-core-devel mailing list