Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

[Aurélien Gâteau]

> On Aug. 9, 2013, 2:59 p.m., Stephen Kelly wrote:
> > Have you tried kdepim applications with this patch too? Many of them use this class.
> 
> Aurélien Gâteau wrote:
>     I just grepped in kdepim, it seems only kmail-mobile makes use of it. It looks like it's working, but I am not familiar with this application so I am adding mbholender to the reviewer.
> 
> Michael Bohlender wrote:
>     I am only a GSoC student and I am not familiar with the breadcrumbnavigation part where KLinkItemSelectionModel is used. The patch looks fine to me but I can test it with kmail-mobile if you want me to. I don't know the kdelibs workflow. Could you push a feature branch that I can quickly checkout and build or do I need to apply the patch manually to test it ?

Would be awesome if you could test it locally. If you already have a kdelibs build it should be straightforward to apply the patch and build with it (or you can use this script I put together some time ago to apply reviewboard patches: https://gist.github.com/agateau/3637858 )


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111953/#review37417
-----------------------------------------------------------


On Aug. 14, 2013, 9:30 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111953/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 9:30 a.m.)
> 
> 
> Review request for kdelibs, Michael Bohlender and Stephen Kelly.
> 
> 
> Description
> -------
> 
> In addition to synchronizing selection, make KLinkItemSelectionModel also synchronize the current index.
> 
> This fixes a bug in Gwenview where image operations are not applied to the correct images when multiple images are selected.
> 
> 
> This addresses bug 322850.
>     http://bugs.kde.org/show_bug.cgi?id=322850
> 
> 
> Diffs
> -----
> 
>   kdeui/itemviews/klinkitemselectionmodel.h 392da46 
>   kdeui/itemviews/klinkitemselectionmodel.cpp ee55d4f 
>   kdeui/tests/klinkitemselectionmodeltest.h f3e0fd1 
>   kdeui/tests/klinkitemselectionmodeltest.cpp c3f7132 
> 
> Diff: http://git.reviewboard.kde.org/r/111953/diff/
> 
> 
> Testing
> -------
> 
> - Extended unit-tests to test the current index is synchronized.
> - Verified the bug is fixed in Gwenview.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130814/8f6a9101/attachment.htm>