Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

Commit Hook null at kde.org
Wed Aug 14 08:30:08 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111953/
-----------------------------------------------------------

(Updated Aug. 14, 2013, 7:30 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs, Michael Bohlender and Stephen Kelly.


Description
-------

In addition to synchronizing selection, make KLinkItemSelectionModel also synchronize the current index.

This fixes a bug in Gwenview where image operations are not applied to the correct images when multiple images are selected.


This addresses bug 322850.
    http://bugs.kde.org/show_bug.cgi?id=322850


Diffs
-----

  kdeui/itemviews/klinkitemselectionmodel.h 392da46 
  kdeui/itemviews/klinkitemselectionmodel.cpp ee55d4f 
  kdeui/tests/klinkitemselectionmodeltest.h f3e0fd1 
  kdeui/tests/klinkitemselectionmodeltest.cpp c3f7132 

Diff: http://git.reviewboard.kde.org/r/111953/diff/


Testing
-------

- Extended unit-tests to test the current index is synchronized.
- Verified the bug is fixed in Gwenview.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130814/e335dff6/attachment.htm>


More information about the kde-core-devel mailing list