Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

[Jeremy Paul Whiting]

> On Aug. 13, 2013, 12:06 p.m., Gabi Sarkis wrote:
> > Ship It!
> 
> Gabi Sarkis wrote:
>     Sorry about that. How do I go about "Shipping it"?
>     
>     Thanks
> 
> Yuri Chornoivan wrote:
>     Just commit it into the repo or ask someone to do it for you.
>     
>     Commit message should contain a separate string "REVIEW: 111952" to close this RR.
> 
> Jeremy Paul Whiting wrote:
>     Gabi, Let me know if you don't have a kde account and I'll commit the fix to git myself.
> 
> Gabi Sarkis wrote:
>     Jeremy, Could you commit the fix? I don't have an account. Thanks.

Gabi, I committed the change to both master (KDE 4.12) and KDE/4.11 branches. Apparently I can't close the review though, could you close it as submitted?

thanks


- Jeremy Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111952/#review37713
-----------------------------------------------------------


On Aug. 8, 2013, 1:12 p.m., Gabi Sarkis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111952/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2013, 1:12 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Currently, the mimetypes used to check xz and lzma packages downloaded by knewstuff are those of compressed files: application/x-xz and application/x-lzma. Downloads from kdelooks are provided as compressed tar archives.
> This patch corrects the mimetypes to those of compressed archives.
> 
> 
> This addresses bug 287913.
>     http://bugs.kde.org/show_bug.cgi?id=287913
> 
> 
> Diffs
> -----
> 
>   plasma/package.cpp cd3702c 
> 
> Diff: http://git.reviewboard.kde.org/r/111952/diff/
> 
> 
> Testing
> -------
> 
> Tested locally and the Plasma themes Helium and Silicon are now correctly extracted and installed from the Workspace Appearance KCM.
> 
> 
> Thanks,
> 
> Gabi Sarkis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130813/af21d7d1/attachment.htm>