Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

Aurélien Gâteau agateau at kde.org
Tue Aug 13 16:59:52 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111953/
-----------------------------------------------------------

(Updated Aug. 13, 2013, 5:59 p.m.)


Review request for kdelibs, Michael Bohlender and Stephen Kelly.


Changes
-------

Added mbohlender to the review since kmail-mobile uses KLinkItemSelectionModel


Description
-------

In addition to synchronizing selection, make KLinkItemSelectionModel also synchronize the current index.

This fixes a bug in Gwenview where image operations are not applied to the correct images when multiple images are selected.


This addresses bug 322850.
    http://bugs.kde.org/show_bug.cgi?id=322850


Diffs
-----

  kdeui/itemviews/klinkitemselectionmodel.h 392da46 
  kdeui/itemviews/klinkitemselectionmodel.cpp ee55d4f 
  kdeui/tests/klinkitemselectionmodeltest.h f3e0fd1 
  kdeui/tests/klinkitemselectionmodeltest.cpp c3f7132 

Diff: http://git.reviewboard.kde.org/r/111953/diff/


Testing
-------

- Extended unit-tests to test the current index is synchronized.
- Verified the bug is fixed in Gwenview.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130813/6d9b5ff8/attachment.htm>


More information about the kde-core-devel mailing list