Review Request 111992: Activity bar in QML.

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/#review37696
-----------------------------------------------------------



plasma/generic/applets/activitybar/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/111992/#comment27847>

    Copyright should be in the form:
    
    Copyright <year> <name> <email>



plasma/generic/applets/activitybar/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/111992/#comment27853>

    whitepace?



plasma/generic/applets/activitybar/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/111992/#comment27849>

    space after if and before (



plasma/generic/applets/activitybar/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/111992/#comment27850>

    if (



plasma/generic/applets/activitybar/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/111992/#comment27852>

    move to end of item



plasma/generic/applets/activitybar/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/111992/#comment27851>

    if (



plasma/generic/applets/activitybar/package/metadata.desktop
<http://git.reviewboard.kde.org/r/111992/#comment27848>

    Not in line with header, where it's GPLv2 or later


- Sebastian Kügler


On Aug. 13, 2013, 12:37 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111992/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 12:37 p.m.)
> 
> 
> Review request for kde-workspace and Marco Martin.
> 
> 
> Description
> -------
> 
> Activity bar applet ported in QML.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb 
>   plasma/generic/applets/activitybar/Messages.sh e73df21 
>   plasma/generic/applets/activitybar/activitybar.h b95cb0c 
>   plasma/generic/applets/activitybar/activitybar.cpp e66bf04 
>   plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de 
> 
> Diff: http://git.reviewboard.kde.org/r/111992/diff/
> 
> 
> Testing
> -------
> 
> Works, Tested in plasmoidviewer and desktop
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130813/64647c93/attachment.htm>