Review Request 111992: Activity bar in QML.

[David Edmundson]

> On Aug. 11, 2013, 11:39 p.m., David Edmundson wrote:
> > plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 41
> > <http://git.reviewboard.kde.org/r/111992/diff/4/?file=178058#file178058line41>
> >
> >     If you want to optimise, you can make TabBar the root item. 
> >     
> >     i.e  instead of
> >     
> >     Item {
> >      TabBar {
> >      }
> >     }
> >     
> >     we can just have 
> >     TabBar {
> >     
> >     }
> >     
> >     
> >     this automatically fixes the implicitWidth/Height change suggested above.
> 
> Bhushan Shah wrote:
>     Item is root because of PlasmaCore.DataSource and setup function.

You can just move them inside the TabBar. It would still work.

Not an essential change though.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/#review37549
-----------------------------------------------------------


On Aug. 13, 2013, 4:11 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111992/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 4:11 a.m.)
> 
> 
> Review request for kde-workspace and Marco Martin.
> 
> 
> Description
> -------
> 
> Activity bar applet ported in QML.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/activitybar/Messages.sh e73df21 
>   plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb 
>   plasma/generic/applets/activitybar/activitybar.h b95cb0c 
>   plasma/generic/applets/activitybar/activitybar.cpp e66bf04 
>   plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de 
> 
> Diff: http://git.reviewboard.kde.org/r/111992/diff/
> 
> 
> Testing
> -------
> 
> Works, Tested in plasmoidviewer and desktop
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130813/32a91b53/attachment.htm>