Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff
Jeremy Paul Whiting
jpwhiting at kde.org
Tue Aug 13 00:03:43 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111952/#review37625
-----------------------------------------------------------
Ship it!
Looks good to me.
- Jeremy Paul Whiting
On Aug. 8, 2013, 1:12 p.m., Gabi Sarkis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111952/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 1:12 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> Currently, the mimetypes used to check xz and lzma packages downloaded by knewstuff are those of compressed files: application/x-xz and application/x-lzma. Downloads from kdelooks are provided as compressed tar archives.
> This patch corrects the mimetypes to those of compressed archives.
>
>
> This addresses bug 287913.
> http://bugs.kde.org/show_bug.cgi?id=287913
>
>
> Diffs
> -----
>
> plasma/package.cpp cd3702c
>
> Diff: http://git.reviewboard.kde.org/r/111952/diff/
>
>
> Testing
> -------
>
> Tested locally and the Plasma themes Helium and Silicon are now correctly extracted and installed from the Workspace Appearance KCM.
>
>
> Thanks,
>
> Gabi Sarkis
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130812/c5fdc5a4/attachment.htm>
More information about the kde-core-devel
mailing list