Review Request 111992: Activity bar in QML.

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/#review37558
-----------------------------------------------------------



plasma/generic/applets/activitybar/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/111992/#comment27755>

    should avoid sizes in pixels, using units.gridUnit is preferred



plasma/generic/applets/activitybar/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/111992/#comment27754>

    this will break on panels less than 30 px tall



plasma/generic/applets/activitybar/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/111992/#comment27756>

    whitespace s your friend
    
    for (i=0; i<activitySource.sources.length; i++) {



plasma/generic/applets/activitybar/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/111992/#comment27757>

    Here there is an old issue of TabBar that should be addressed one day or another..
    
    it doesn't support vertical formfactors, in a vertical panel will just break. For now, even if will look rather terrible in that case the tabbar should probably just be rotated 90°


- Marco Martin


On Aug. 12, 2013, 3:14 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111992/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 3:14 a.m.)
> 
> 
> Review request for kde-workspace and Marco Martin.
> 
> 
> Description
> -------
> 
> Activity bar applet ported in QML.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb 
>   plasma/generic/applets/activitybar/Messages.sh e73df21 
>   plasma/generic/applets/activitybar/activitybar.h b95cb0c 
>   plasma/generic/applets/activitybar/activitybar.cpp e66bf04 
>   plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de 
> 
> Diff: http://git.reviewboard.kde.org/r/111992/diff/
> 
> 
> Testing
> -------
> 
> Works, Tested in plasmoidviewer and desktop
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130812/5cf89185/attachment.htm>