Review Request 111992: Activity bar in QML.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/#review37549
-----------------------------------------------------------



plasma/generic/applets/activitybar/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/111992/#comment27744>

    This probably needs some minimum sizes set. Otherwise you can make the plasmoid invisible :)
    
    I would also be sure to set an implicitWidth and implicitHeight to the same as the TabBar.
    (i.e implicitWidth: tabBar.implicitWidth



plasma/generic/applets/activitybar/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/111992/#comment27745>

    If you want to optimise, you can make TabBar the root item. 
    
    i.e  instead of
    
    Item {
     TabBar {
     }
    }
    
    we can just have 
    TabBar {
    
    }
    
    
    this automatically fixes the implicitWidth/Height change suggested above.



plasma/generic/applets/activitybar/package/metadata.desktop
<http://git.reviewboard.kde.org/r/111992/#comment27742>

    Is this a sensible default?
    Tab bars typically wide and flat



plasma/generic/applets/activitybar/package/metadata.desktop
<http://git.reviewboard.kde.org/r/111992/#comment27743>

    You are not Marco
    
    Good to see you're aiming high though :)


- David Edmundson


On Aug. 11, 2013, 11:39 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111992/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2013, 11:39 a.m.)
> 
> 
> Review request for kde-workspace and Marco Martin.
> 
> 
> Description
> -------
> 
> Activity bar applet ported in QML.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb 
>   plasma/generic/applets/activitybar/Messages.sh e73df21 
>   plasma/generic/applets/activitybar/activitybar.h b95cb0c 
>   plasma/generic/applets/activitybar/activitybar.cpp e66bf04 
>   plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de 
> 
> Diff: http://git.reviewboard.kde.org/r/111992/diff/
> 
> 
> Testing
> -------
> 
> Works, Tested in plasmoidviewer and desktop
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130811/a0c63cd7/attachment.htm>