Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

[Milian Wolff]

On Monday 05 August 2013 19:17:49 Albert Astals Cid wrote:
> El Dilluns, 5 d'agost de 2013, a les 01:34:07, Milian Wolff va escriure:
> > On Sunday 04 August 2013 16:35:20 Albert Astals Cid wrote:
> > > El Diumenge, 4 d'agost de 2013, a les 00:29:06, Milian Wolff va 
escriure:
> > > > On Sunday 04 August 2013 00:28:17 Milian Wolff wrote:
> > > > > Hey all,
> > > > > 
> > > > > I'd like to backport this comment from kdelibs master to KDE 4.11,
> > > > > is
> > > > > this
> > > > > OK?
> > > > 
> > > > Ahum, sorry - accidentally hit "ctrl + enter".
> > > > 
> > > > commit 0bd9529fc3d9382dc748a2f7f5306903c674151c
> > > > Author: Milian Wolff <mail at milianw.de>
> > > > Date:   Sun Jul 21 21:07:36 2013 +0200
> > > > 
> > > >     Add basic support for clang in FindKDE4Internal.cmake.
> > > > 
> > > > This is the commit I'm talking about. Any objections?
> > > 
> > > I don't see a huge problem with it with my release team hat, I'd still
> > > prefer you wait for someone more in the know of the area to ACK the
> > > backport.
> > 
> > Until when do I have time to wait? I.e. what would be the latest I'd have
> > to merge this code into KDE/4.11?
> 
> http://techbase.kde.org/Schedules/KDE4/4.11_Release_Schedule

Thanks.

I'm out of the loop, since this is so close to the final release I'm not sure 
whether I should get this in...

It should not break anything, since Clang was broken before. But then again, 
who knows?

Could someone please chime in and tell me what to do? The reason why I'd like 
to have it, is because otherwise it's very easy to break code by committing 
crap when you use clang. None of the usual pendantic flags are set, and some 
functional changes can even lead to random crashes (esp. related to global 
statics).

So... what do you think? Btw, is there still no BSD using clang by default to 
build KDE? How did they manage to get this to work without the patch?

Bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de