Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties
Commit Hook
null at kde.org
Mon Aug 5 16:26:32 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111852/
-----------------------------------------------------------
(Updated Aug. 5, 2013, 3:26 p.m.)
Status
------
This change has been marked as submitted.
Review request for kdelibs, Albert Astals Cid and David Faure.
Description
-------
Comment information is found in the XML data so needs to be loaded before returning property values. The same would apply for the Patterns property if you were to query that from the property name instead of the KMimeType::patterns() method.
This addresses bug 322578.
http://bugs.kde.org/show_bug.cgi?id=322578
Diffs
-----
kdecore/services/kmimetype.cpp d748523
kdecore/services/kmimetype_p.h 6ffee71
kdecore/tests/kmimetypetest.h c38b036
kdecore/tests/kmimetypetest.cpp da32e2c
Diff: http://git.reviewboard.kde.org/r/111852/diff/
Testing
-------
Executed the same code posted in the bug report, here's the output:
("Name", "Comment", "Patterns", "Icon")
QVariant(QString, "PNG image")
Thanks,
David Narváez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130805/d8cab9e5/attachment.htm>
More information about the kde-core-devel
mailing list