Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111870/#review37041
-----------------------------------------------------------



kdecore/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/111870/#comment27348>

    why did you move that outside? is this being used elsewhere? if so, I can't see it by the diff apparently.



kdecore/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/111870/#comment27349>

    the indentation is broken here, no? should be two spaces like the rest of the file.



kdecore/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/111870/#comment27351>

    isDir looks like an outparam but is used like an in-param here. will this work for all cases where this function is being called when inotify is present?


- Milian Wolff


On Aug. 3, 2013, 9:28 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111870/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2013, 9:28 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> At first i wasn't intending to even ask a reviewrequest for this because i want to fix an issue that is well described in my thread: "KDirWatch bug and the analysis. Help is welcome!" on kde-core-devel. However, while starting on fixing that issue i noticed that this would be a nice small improvement to have. It also prevents one stat call that was used to determine if "entry" was a file or folder, but inotify already gives us that information.
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kdirwatch.cpp 95ee3d3 
> 
> Diff: http://git.reviewboard.kde.org/r/111870/diff/
> 
> 
> Testing
> -------
> 
> Compiles just fine.
> Runs fine, i haven't seen any issues thus far.
> Oh and it passes all kio test cases but i specially note the following:
> kdirwatchtest
> kdirlistertest
> kdirmodeltest
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130803/7ac6e35c/attachment.htm>