Broken tests in kdelibs due to kio change

[Albert Astals Cid]

El Dissabte, 3 d'agost de 2013, a les 13:39:40, Dawit A va escriure:
> OK. I see why those tests failed and I fixed them not to anymore. Updating
> the clibpboard in KIO introduced a dependency on QtGui.
> Hence QTEST_KDEMAIN( KDirModelTest, NoGUI ) has to be changed
> to QTEST_KDEMAIN( KDirModelTest, GUI ).
> 
> Hmm... I am curious if the dependency on QClipboard makes it difficult to
> split this into core/gui in frameworks?

I am not a KIO specialist, is this new runtime dependency ok that late in the 
release cycle? 

Can anyone more in the know [than me] comment?

If it is, it seems some kde-runtime tests also have to be fixed.

http://build.kde.org/view/KDE%20SC%20stable/job/kde-runtime_stable/291/

Cheers,
  Albert

> 
> On Sat, Aug 3, 2013 at 1:16 PM, Dawit A <adawit at kde.org> wrote:
> > Hmm... I fail to see how my changes break those unit tests. Perhaps
> > changing fileundomanager from NoGui to Gui did it? Anyhow, I will try to
> > look into it.
> > 
> > On Sat, Aug 3, 2013 at 10:25 AM, Albert Astals Cid <aacid at kde.org> wrote:
> >> Dawit, kdelibs people, there are 4 tests that broke in
> >> very-close-to-release
> >> 4.11 branch with a change from yesterday to kio.
> >> 
> >> http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/735/
> >> 
> >> Can you guys please have a look and fix those failing tests?
> >> 
> >> Also please please please make sure you either run the tests before
> >> commiting
> >> changes so late in the release cycle *and* even if you run them please
> >> check
> >> with jenkins to see his opinion on your changes :)
> >> 
> >> Cheers,
> >> 
> >>   Albert