Review Request 109828: Separate configuration from history in Klipper's popup menu

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109828/#review31820
-----------------------------------------------------------



klipper/klipper.h
<http://git.reviewboard.kde.org/r/109828/#comment23719>

    Missing indentation?



klipper/tray.h
<http://git.reviewboard.kde.org/r/109828/#comment23720>

    (indentation again)



klipper/tray.cpp
<http://git.reviewboard.kde.org/r/109828/#comment23721>

    Put m_klipper->actionCollection() into a local variable to avoid calling it 10 times.



klipper/tray.cpp
<http://git.reviewboard.kde.org/r/109828/#comment23722>

    Strange spaces around ->



klipper/tray.cpp
<http://git.reviewboard.kde.org/r/109828/#comment23723>

    Why this change?



klipper/tray.cpp
<http://git.reviewboard.kde.org/r/109828/#comment23724>

    Remove default value from the implementation (some compilers won't even accept this).



klipper/tray.cpp
<http://git.reviewboard.kde.org/r/109828/#comment23725>

    What are the arguments for, if the slot ignores them?


- David Faure


On April 3, 2013, 10:50 a.m., David Baum wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109828/
> -----------------------------------------------------------
> 
> (Updated April 3, 2013, 10:50 a.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> Splitts the big klipper menu into two separate ones.
> left click -> clipboard history
> right click -> options/configuration
> 
> 
> This addresses bug 93649.
>     http://bugs.kde.org/show_bug.cgi?id=93649
> 
> 
> Diffs
> -----
> 
>   klipper/history.h 52084faee62f455747398994ba30ca9c3e1a8b07 
>   klipper/klipper.h bbfd9c9eefe7bb246fd851ff407b11d6257bc495 
>   klipper/klipper.cpp cf41bd2ea6d8b6b6f99fc43fdacce140fb07ac8f 
>   klipper/klipperpopup.cpp bff2c2569a507e9e933c7f1575b871c2803e0dfa 
>   klipper/tray.h e9e962a39d66c4f9bdcda484d5913374bf76c320 
>   klipper/tray.cpp 32088599df632b6c192e9ee84feaf1e54f889182 
> 
> Diff: http://git.reviewboard.kde.org/r/109828/diff/
> 
> 
> Testing
> -------
> 
> Known bug: Both menus have a different title, setTitle seems to have no effect for the context menu.
> 
> 
> Thanks,
> 
> David Baum
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130430/99b3913b/attachment.htm>