Review Request 110083: Make kdepim libs optional dependency for libkfbapi
Martin Klapetek
martin.klapetek at gmail.com
Mon Apr 29 12:18:57 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110083/
-----------------------------------------------------------
(Updated April 29, 2013, 11:18 a.m.)
Review request for kdelibs and KDEPIM-Libraries.
Changes
-------
Upload correct patch :)
Description
-------
kdepim-libs are needed in the facebook library only to return user info as KABC::Addressee and note as KMime::Message, plus events use KCalCore classes. This patch makes dependency on kdepim-libs optional and disables building the event classes completely in case kdepim-libs was not found.
Diffs (updated)
-----
CMakeLists.txt 5aefdcf
LibKFbAPI-KDEPIM.pc.in PRE-CREATION
LibKFbAPI-KDEPIMConfig.cmake.in PRE-CREATION
LibKFbAPI.pc.in af537d1
libkfbapi/CMakeLists.txt dac62bc
libkfbapi/commentinfo.h e5578c7
libkfbapi/kdepim-utils.h PRE-CREATION
libkfbapi/kdepim-utils.cpp PRE-CREATION
libkfbapi/likeinfo.h e06052e
libkfbapi/noteinfo.h 2492db1
libkfbapi/noteinfo.cpp 154593d
libkfbapi/notificationinfo.h a882694
libkfbapi/userinfo.h ac22a7e
libkfbapi/userinfo.cpp 26c64da
libkfbapi/userinfoparser_p.h 0189a17
Diff: http://git.reviewboard.kde.org/r/110083/diff/
Testing
-------
Builds correctly here in both cases
Thanks,
Martin Klapetek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130429/5ba937e3/attachment.htm>
More information about the kde-core-devel
mailing list