Review Request 110083: Make kdepim libs optional dependency for libkfbapi

[Martin Klapetek]

> On April 26, 2013, 8:09 a.m., Kevin Krammer wrote:
> > I am wondering if it wouldnt't make more sense to have the PIM integration as a separate lib, so that libkfbapi has a stable API and ABI at all times.

I like that idea. I'll update the review with it then :)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110083/#review31608
-----------------------------------------------------------


On April 26, 2013, 7:37 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110083/
> -----------------------------------------------------------
> 
> (Updated April 26, 2013, 7:37 a.m.)
> 
> 
> Review request for kdelibs and KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> kdepim-libs are needed in the facebook library only to return user info as KABC::Addressee and note as KMime::Message, plus events use KCalCore classes. This patch makes dependency on kdepim-libs optional and disables building the event classes completely in case kdepim-libs was not found.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5aefdcf 
>   libkfbapi/CMakeLists.txt dac62bc 
>   libkfbapi/commentinfo.h e5578c7 
>   libkfbapi/config.h.cmake PRE-CREATION 
>   libkfbapi/likeinfo.h e06052e 
>   libkfbapi/noteinfo.h 2492db1 
>   libkfbapi/noteinfo.cpp 154593d 
>   libkfbapi/notificationinfo.h a882694 
>   libkfbapi/userinfo.h ac22a7e 
>   libkfbapi/userinfo.cpp 26c64da 
>   libkfbapi/userinfoparser_p.h 0189a17 
> 
> Diff: http://git.reviewboard.kde.org/r/110083/diff/
> 
> 
> Testing
> -------
> 
> Builds correctly here in both cases
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130429/f676284e/attachment.htm>