Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110225/
-----------------------------------------------------------

(Updated April 28, 2013, 1:28 p.m.)


Review request for kdelibs, David Faure and Jekyll Wu.


Description
-------

The current algorithm that tries to find out what mount point a path belongs to only checks if the first part of the string matches the mount point. The problem is that /books is then considered a path inside /book, which is obviously wrong.

I propose to fix this by verifying that either the mount point ends with a '/', or the first char of the path that does not match the mount point is a '/'. I've factored this check out into a separate function to keep the code readable.

Many thanks to Jekyll Wu, who analyzed this bug and found the right place in the code.


This addresses bug 193298.
    http://bugs.kde.org/show_bug.cgi?id=193298


Diffs (updated)
-----

  kdecore/io/kmountpoint.cpp aa7a6b1 

Diff: http://git.reviewboard.kde.org/r/110225/diff/


Testing
-------

Works for me.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130428/1e835c9a/attachment.htm>