Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

[Thomas Lübking]

> On April 27, 2013, 7:40 a.m., Thomas Lübking wrote:
> > plasma/private/dialogshadows.cpp, line 371
> > <http://git.reviewboard.kde.org/r/110138/diff/2/?file=141212#file141212line371>
> >
> >     this looks slightly like a recursion?
> >     (i think void DialogShadows::Private::freeX11Pixmaps() and void DialogShadows::Private::clearPixmaps() are twisted)

RR110029 was submitted a week ago.

However I don't see a self-calling freeX11Pixmaps() that does not free the pixmaps but clear the caches there... ;-)
(look at your patched version, lines 368-371)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110138/#review31652
-----------------------------------------------------------


On April 27, 2013, 8:01 a.m., Ömer Fadıl Usta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110138/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 8:01 a.m.)
> 
> 
> Review request for kdelibs, Aaron J. Seigo, Martin Gräßlin, and Marco Martin.
> 
> 
> Description
> -------
> 
> I was getting lots of errors while moving my mouse over system tray before this patch.( https://git.reviewboard.kde.org/r/110029/ ) 
> Also this patch fixes a forgetten check before freeing a already freed pixmap
> 
> 
> Diffs
> -----
> 
>   plasma/private/dialogshadows_p.h a2d62cc 
>   plasma/private/dialogshadows.cpp e787fd4 
> 
> Diff: http://git.reviewboard.kde.org/r/110138/diff/
> 
> 
> Testing
> -------
> 
> Looks like it is working fine
> 
> 
> Thanks,
> 
> Ömer Fadıl Usta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130427/f1601de9/attachment.htm>