Review Request 106581: Make KFileDialog remember settings

[Boudewijn Rempt]

> On April 10, 2013, 10:52 p.m., Albert Astals Cid wrote:
> > Aurelien: David: apaku: Ping?
> 
> Aurélien Gâteau wrote:
>     Still in my TODO list :/

Looks there _is_ user demand:

16:17:17 < RaktenUser> while I am compiling.... Why are the mounts resolved to places in the file requester? We had 
                       put a lot of effort to have special filestructure which need to be honored e.g. for the 
                       asset managment systems. I tired to turned that off but I did not find a option.
16:18:19 < boud> that's stuff kde does by default for us.
16:18:53 < boud> I don't know exactly how to configure that, but I can take a look
16:19:58 < RaktenUser> hm in dolphin i can just uncheck the places sidebar ...
16:20:38 < boud> well, that works in krita too, doesn' tit?
16:20:52 < RaktenUser> no. 
16:21:00 < boud> ah, the setting isn't remembered
16:26:32 < boud> https://git.reviewboard.kde.org/r/106581/... in dolphin it's remembered as part of the dockers 
                 setting
16:26:44 < boud> but for kfiledialog/kfilewidget it's pending


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106581/#review30891
-----------------------------------------------------------


On Oct. 2, 2012, 10:55 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106581/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 10:55 a.m.)
> 
> 
> Review request for kdelibs and Andreas Pakulat.
> 
> 
> Description
> -------
> 
> This patch makes KFileDialog remember settings such as which view mode is selected and whether the places sidebar should be visible.
> 
> Original code tried to save those to kdeglobals so that changes would be shared among all applications but it did so the wrong way. The patch writes the configuration to kdeglobals correctly, but saves the KDirOperator to the application config file (KDirOperator configuration settings are sort settings, show preview, show hidden files, view style (icon, detail, treeview))
> 
> There are two reasons for not saving KDirOperator config to kdeglobals:
> 
> 1. It is right now not possible to tell KDirOperator::writeConfig() to save to kdeglobals. It could be done by adding a new version of writeConfig() which would accept a KConfigBase::WriteFlags argument though.
> 
> 2. It probably would not be a good idea to remember KDirOperator settings globally anyway because depending on the application one may want to use different settings.
> For example if user wants to select images or videos he might set the file dialog to show big icons and the preview pane (so that videos can be played). This setup would however not be adapted in an application where one wants to select a text file.
> 
> 
> This addresses bug 139475.
>     http://bugs.kde.org/show_bug.cgi?id=139475
> 
> 
> Diffs
> -----
> 
>   kfile/kfilewidget.cpp 8e2f967 
> 
> Diff: http://git.reviewboard.kde.org/r/106581/diff/
> 
> 
> Testing
> -------
> 
> Tested with two different KDE applications. Settings are correctly remembered.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130426/c36fe1d0/attachment.htm>