Review Request 110083: Make kdepim libs optional dependency for libkfbapi

Martin Klapetek martin.klapetek at
Fri Apr 26 08:37:23 BST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated April 26, 2013, 7:37 a.m.)

Review request for kdelibs and KDEPIM-Libraries.


As this is my first patch making a lib build stuff conditionally, I'd like some opinion on this.



kdepim-libs are needed in the facebook library only to return user info as KABC::Addressee and note as KMime::Message, plus events use KCalCore classes. This patch makes dependency on kdepim-libs optional and disables building the event classes completely in case kdepim-libs was not found.


  CMakeLists.txt 5aefdcf 
  libkfbapi/CMakeLists.txt dac62bc 
  libkfbapi/commentinfo.h e5578c7 
  libkfbapi/config.h.cmake PRE-CREATION 
  libkfbapi/likeinfo.h e06052e 
  libkfbapi/noteinfo.h 2492db1 
  libkfbapi/noteinfo.cpp 154593d 
  libkfbapi/notificationinfo.h a882694 
  libkfbapi/userinfo.h ac22a7e 
  libkfbapi/userinfo.cpp 26c64da 
  libkfbapi/userinfoparser_p.h 0189a17 



Builds correctly here in both cases


Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list