Review Request 109841: Use https for web shortcuts

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109841/#review31268
-----------------------------------------------------------


Editing translations is pointless, the script that fills them in from .po files (called "scripty") will revert all that the night afterwards, and then as translators update their translations, the https will slowly come back in.
If you want to avoid that, you'd have to also update the .po files in i18n - but that's a humongous checkout to make.

So I would suggest reducing the patch to just changing the untranslated key, and letting the rest happen over time.


- David Faure


On April 3, 2013, 2:59 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109841/
> -----------------------------------------------------------
> 
> (Updated April 3, 2013, 2:59 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Use encrypted https for the web shortcuts that support it. Make sure the site does not redirect to unencrypted connection. (exception: google feeling lucky)
> Other shortcuts need more changes to support SSL. A lot are outdated, I'll post a patch for them soonish.
> 
> This small change should improve protection against networks sniffers.
> 
> 
> This addresses bug 308029.
>     http://bugs.kde.org/show_bug.cgi?id=308029
> 
> 
> Diffs
> -----
> 
>   kurifilter-plugins/ikws/searchproviders/blip.desktop b308ad3 
>   kurifilter-plugins/ikws/searchproviders/facebook.desktop 1ab6de1 
>   kurifilter-plugins/ikws/searchproviders/flickrcc.desktop 8ab0044 
>   kurifilter-plugins/ikws/searchproviders/github.desktop 5af6fe6 
>   kurifilter-plugins/ikws/searchproviders/gitorious.desktop 2a801d9 
>   kurifilter-plugins/ikws/searchproviders/google.desktop 86fc2e3 
>   kurifilter-plugins/ikws/searchproviders/google_advanced.desktop 5ec1bba 
>   kurifilter-plugins/ikws/searchproviders/google_groups.desktop 7366c90 
>   kurifilter-plugins/ikws/searchproviders/google_lucky.desktop 8b9837f 
>   kurifilter-plugins/ikws/searchproviders/google_news.desktop 1ef636c 
>   kurifilter-plugins/ikws/searchproviders/identica_groups.desktop 4d3efe8 
>   kurifilter-plugins/ikws/searchproviders/identica_notices.desktop 2ed0e5f 
>   kurifilter-plugins/ikws/searchproviders/identica_people.desktop d233cb8 
>   kurifilter-plugins/ikws/searchproviders/kde_forums.desktop e7acaaa 
>   kurifilter-plugins/ikws/searchproviders/wolfram_alpha.desktop 6a8bda6 
>   kurifilter-plugins/ikws/searchproviders/youtube.desktop 0549216 
> 
> Diff: http://git.reviewboard.kde.org/r/109841/diff/
> 
> 
> Testing
> -------
> 
> All shortcuts use https and have a valid ssl certificate.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130419/c1f6bdc7/attachment.htm>