Review Request 110057: Fix mem leaks in kunitconversion

[Dario Cambié]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110057/
-----------------------------------------------------------

(Updated April 16, 2013, 9:31 p.m.)


Review request for kdelibs.


Changes
-------

fix missing newline at the end of file


Description
-------

Little patch for memory leaks in kunitconversion: functions dynamically created were never deleted.
Not sure if the patch is correct (C++ is not my language at all) but it seems to "work for me".


Diffs (updated)
-----

  kunitconversion/angle.cpp 6333925 
  kunitconversion/fuel_efficiency.cpp 1914fab 

Diff: http://git.reviewboard.kde.org/r/110057/diff/


Testing
-------

Compiles, no more mem leaks according to valgrind.

valgrind before (e.g.):
==8754== 8 bytes in 1 blocks are definitely lost in loss record 110 of 644
==8754==    at 0x4C2AF8E: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==8754==    by 0x5A3EE11: Angle::Angle() (angle.cpp:51)

valgrind after:
no such alert


File Attachments (updated)
----------------


  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/16/0001-Fix-minor-mem-leaks-in-kunitconversion-angle-and-fue.patch


Thanks,

Dario Cambié

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130416/5788ac1a/attachment.htm>