Review Request 110042: Find Qt5 version of DBusMenuQt

Rolf Eike Beer kde at opensource.sf-tec.de
Tue Apr 16 15:30:15 BST 2013


Am Dienstag 16 April 2013, 13:26:23 schrieb Frederik Gladhorn:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110042/
> -----------------------------------------------------------
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Build fix for dbusmenu qt5 changes.
> This appends the 5 to include path and lib dir in the find module.
> Also rename the whole thing to not conflict with the Qt 4 version.

Since DBusMenuQt5 is obviously a rather new thing I would vote for putting a 
DBusMenuQt5Config.cmake into that project itself and install that. That would 
allow everyone to use it with CMake once the module itself is installed, 
without any need for a Find*.cmake module.

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130416/6291cc20/attachment.sig>


More information about the kde-core-devel mailing list