[kdelibs] kded: Disable KHostnameD in KDED

Martin Sandsmark martin.sandsmark at kde.org
Mon Apr 15 12:39:34 BST 2013


On Mon, Apr 15, 2013 at 01:17:19PM +0200, Martin Gräßlin wrote:
> well not stupidly polling is a bug fix, isn't it?

That's really trying to twist semantics, IMHO. Polling every five seconds
like it is intended to is not a bug, and now it breaks even worse (by locking
out everyone who change their hostname from their sessions, not just with a
different X setup).


> I think in this case it is fine, after all core-devel is on CC and the code is 
> not yet removed

The point of reviews is to catch stupid mistakes like the one Rolf pointed
out (and preferrably have this discussion before-hand, instead of having to
go in and revert stuff).


-- 
Martin Sandsmark





More information about the kde-core-devel mailing list