[kdelibs] kded: Disable KHostnameD in KDED

[Rolf Eike Beer]

Am 15.04.2013 12:43, schrieb Àlex Fiestas:
> Git commit 8d99f863724c6fe76d008da4455fa177af2ee3ee by Àlex Fiestas.
> Committed on 15/04/2013 at 12:24.
> Pushed by afiestas into branch 'master'.
> 
> Disable KHostnameD in KDED
> 
> KHostnameD monitors the hostname by polling gethostname every 5 
> seconds
> to adapt some bits of the environment in case the hostname changes. In
> systems with only a local X server this does not matter at all. In
> systems using remote X you should not change your hostname, period.
> In most distributions changing your hostname no longuer breaks X 
> access
> for local applications since xhost is configured correctly. In summary
> there is NO reason to keep this around.
> 
> Besides that, kdontchangethehostname (binay that is called when the
> hostname is changed) does not work if your DISPLAY env is like ":0"
> which is the format that can be found in all distributions nowdays
> (old format was domain/[unix,tcp,...]:0).
> 
> Even fixing it, most distributions use a global Xauthority pointed by
> the DM or XAUTHORITY env which points to either /run/*dm/... or in
> /tmp/user.... Meaning that the most important adaptation to the new
> hostname that kdontchangethehostname does won't work either.
> 
> If this is ever enabled again the polling should be removed by either
> using systemd-hostnamed or inotify+/etc/hostname but polling won't
> be accepted.
> 
> This commits only disables the code, if nobody complains I will remove
> the full code before 4.11 is out.
> 
> CCMAIL:kde-core-devel at kde.org
> 
> M  +1    -1    kded/kded.cpp
> 
> http://commits.kde.org/kdelibs/8d99f863724c6fe76d008da4455fa177af2ee3ee
> 
> diff --git a/kded/kded.cpp b/kded/kded.cpp
> index b594692..b611972 100644
> --- a/kded/kded.cpp
> +++ b/kded/kded.cpp
> @@ -842,7 +842,7 @@ public:
>  #endif
> 
>            if (bCheckHostname)
> -            (void) new KHostnameD(HostnamePollInterval); // Watch
> for hostname changes
> +//             (void) new KHostnameD(HostnamePollInterval); // Watch
> for hostname changes
> 
>            kded->initModules();
>         } else

Nice, now we have

if (bCheckHostname)
    kded->initModules();

This can't be right.

Eike