Review Request 109792: Update 'dim display' algorithm.

[Danny Baumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109792/
-----------------------------------------------------------

(Updated April 13, 2013, 10:53 a.m.)


Review request for kde-workspace, Solid, Dario Freddi, and Oliver Henshaw.


Changes
-------

Updated the patch to only cover actual breakage without introducing new options.


Description
-------

This change does two things:
- No longer dim display before the dim time set by the user elapses.
  This fixes bug #304696
- No longer assume that 0% display brightness produces a visible result.
  This doesn't work with the intel-backlight backlight interface (as it
  turns off the backlight at 0% brightness). According to the kernel
  developers (see [1] and [2]), this isn't a safe assumption to make for
  other backlight interfaces either. Instead of always dimming to 0%,
  make the amount of dimming configurable.

[1]
http://lists.freedesktop.org/archives/intel-gfx/2013-March/026152.html
[2]
http://lists.freedesktop.org/archives/intel-gfx/2013-March/026140.html


This addresses bug 304696.
    http://bugs.kde.org/show_bug.cgi?id=304696


Diffs (updated)
-----

  powerdevil/daemon/actions/bundled/dimdisplay.cpp 11554e3ba5d2f67d4d1de9d61c744c6c40a32d27 

Diff: http://git.reviewboard.kde.org/r/109792/diff/


Testing
-------


Thanks,

Danny Baumann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130413/939bcdc5/attachment.htm>