Review Request 109844: Fixes a Null pointer problem and increase readability

Ömer Fadıl Usta omerusta at gmail.com
Wed Apr 3 17:22:39 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109844/
-----------------------------------------------------------

Review request for kde-workspace.


Description
-------

I have faced a "TaskManager::AlphaSortingStrategy::sortItems: Null Pointer" error in my .xsession_errors file and when i  check cpp i have saw that :
      TaskItem *item = qobject_cast<TaskItem*>(groupable);
on the other hand all checkings for qroupable variable are in other if clauses which are not satisfy all situations.


Diffs
-----

  libs/taskmanager/strategies/alphasortingstrategy.cpp d4dda00 

Diff: http://git.reviewboard.kde.org/r/109844/diff/


Testing
-------


Thanks,

Ömer Fadıl Usta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130403/68ad71ec/attachment.htm>


More information about the kde-core-devel mailing list