Review Request: Part II: cookie configuration dialog to support the accept cookie for session option

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106619/#review19625
-----------------------------------------------------------

Ship it!



konqueror/settings/kio/kcookiespolicies.cpp
<http://git.reviewboard.kde.org/r/106619/#comment15624>

    That's a weird variable name for an item... a bit confusing.



konqueror/settings/kio/kcookiespolicies.cpp
<http://git.reviewboard.kde.org/r/106619/#comment15625>

    Use .value() instead of [] to prevent accidental insertion.


- David Faure


On Sept. 28, 2012, 4:46 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106619/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2012, 4:46 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> This is the configuration dialog portion of the patch necessary to convert the global "Treat all cookies as session cookies" option into a per domain or per cookie configuration.  This patch completes the patch posted at https://git.reviewboard.kde.org/r/106618/.
> 
> 
> This addresses bug 54300.
>     http://bugs.kde.org/show_bug.cgi?id=54300
> 
> 
> Diffs
> -----
> 
>   konqueror/settings/kio/kcookiespolicies.h b035ad5 
>   konqueror/settings/kio/kcookiespolicies.cpp 75d265f 
>   konqueror/settings/kio/kcookiespolicies.ui 6b88b80 
>   konqueror/settings/kio/kcookiespolicyselectiondlg.h d40a0f2 
>   konqueror/settings/kio/kcookiespolicyselectiondlg.ui c7ebb5d 
> 
> Diff: http://git.reviewboard.kde.org/r/106619/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> New Cookie Config dialog
>   http://git.reviewboard.kde.org/r/106619/s/737/
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120930/07c3aa9e/attachment.htm>