Review Request: Part I: Add domain/cookie specific 'accept cookie for session' option to kcookiejar

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106618/#review19622
-----------------------------------------------------------

Ship it!


Looks good. Just a few minor C++ things to fix before commit.


kioslave/http/kcookiejar/kcookiejar.h
<http://git.reviewboard.kde.org/r/106618/#comment15620>

    remove trailing ';' (same on line below)



kioslave/http/kcookiejar/kcookiejar.h
<http://git.reviewboard.kde.org/r/106618/#comment15621>

    Make the method const



kioslave/http/kcookiejar/kcookiejar.h
<http://git.reviewboard.kde.org/r/106618/#comment15622>

    Make method const


- David Faure


On Sept. 28, 2012, 4:54 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106618/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2012, 4:54 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This is a user contributed patch that changes the "Treat all cookies as session cookies" global option into a per domain/cookie option so that the policy can be configured in a more fine grained fashion. It was initially intended to be push upstream for the 4.6 release, but for reasons I do not want to restate again, see http://lists.kde.org/?t=132070395200003&r=1&w=2 if you want the details, the patch never made it in.
> 
> Well I want to push this into kdelibs for the 4.10 release before it is too late. The patch comes complete with unit tests that exercise the new changes and was contributed by Gregorio Guidi. He did all the work and made all the necessary fixes based on feedback from me. I only added code to update the kcookiejar config file and modified a couple of unrelated minor GUI issues. As such I want to reconginze this effort by pushing this patch on his behalf.
> 
> 
> This addresses bug 54300.
>     http://bugs.kde.org/show_bug.cgi?id=54300
> 
> 
> Diffs
> -----
> 
>   kioslave/http/kcookiejar/CMakeLists.txt e5ff3ee 
>   kioslave/http/kcookiejar/kcookiejar.h 896cab7 
>   kioslave/http/kcookiejar/kcookiejar.cpp db4606c 
>   kioslave/http/kcookiejar/kcookiescfg.pl PRE-CREATION 
>   kioslave/http/kcookiejar/kcookiescfg.upd 3c1cd02 
>   kioslave/http/kcookiejar/kcookieserver.cpp c8a61fb 
>   kioslave/http/kcookiejar/kcookiewin.h ce61c5a 
>   kioslave/http/kcookiejar/kcookiewin.cpp 0713cdd 
>   kioslave/http/kcookiejar/tests/cookie_session.test PRE-CREATION 
>   kioslave/http/kcookiejar/tests/cookie_settings.test 7fc1a03 
>   kioslave/http/kcookiejar/tests/kcookiejartest.cpp 5dbe2ca 
> 
> Diff: http://git.reviewboard.kde.org/r/106618/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> new cookie confirmation dialog
>   http://git.reviewboard.kde.org/r/106618/s/736/
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120930/2841b8c6/attachment.htm>