Review Request: Use product as text for pluggable/removable devices

[Alex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106653/#review19613
-----------------------------------------------------------


I decided to make a review because I wonder why we were using description before, was it working better with HAL?

- Alex Fiestas


On Sept. 30, 2012, 12:22 a.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106653/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2012, 12:22 a.m.)
> 
> 
> Review request for kdelibs and Kevin Ottens.
> 
> 
> Description
> -------
> 
> The description is useful for when the device is not hotpluggable/removeable, for example to show:
> 96.3 GiB Hard Drive
> 15.1 GiB Hard Drive
> 
> instead of two identical labels.
> 
> But when it comes to removable/hotpluggable we want to show the Product to be able to show:
> 
> Nokia N9
> Nexus 7
> 
> Instead of 
> Portable Media Player
> Portable Media Player
> 
> Screenshots from this review are applicable:
> https://git.reviewboard.kde.org/r/106637/
> 
> 
> Diffs
> -----
> 
>   kfile/kfileplacesitem.cpp 3ada0c3 
> 
> Diff: http://git.reviewboard.kde.org/r/106653/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120930/ec194e65/attachment.htm>