Review request reminder: kded-appmenu
afiestas at kde.org
Sat Sep 29 17:05:45 BST 2012
On Wednesday 26 September 2012 14:58:55 Cedric Bellegarde wrote:
> i'm waiting for some code review on kded-appmenu module:
> Martin Gräßlin tells me to send a reminder here before commiting. I need to
> put this in kde-workspace before patching with:
> As i'm now plasma-widget-menubar maintainer, i will release a compatible
> version as soon as this is released with KDE.
> For libkappmenu, it's not needed inside KDE as dbusmenu will be deprecated
> by GMenuModel.
> So, my next works will be:
> - start working on QMenuModel with Qt devs and Renato Araujo Oliveira Filho
> from Canonical
> - add support for QMenuModel in kded-appmenu
I was wondering, can't the kded be loaded on demand? what if somebody doesn't
care about appmenu?
Coding wise everything seems ok, only a few tips I apply to my code but you
don't have to :p
-Don't use arguments names like "b" even if it is a bool :p
-Return asap, instead of having super huge blocks of conditionals.
As I said, personal "code clean" tips, don't change anything if you don't
Cheers and good work!
More information about the kde-core-devel