Review Request: Avoid creating an empty .tbcache for bookmarks

David Faure faure at kde.org
Sat Sep 29 09:29:09 BST 2012



> On Sept. 29, 2012, 8:25 a.m., David Faure wrote:
> > Ah, thanks, now I understand. Please commit.

The speedup idea is good too, feel free to switch to that solution.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106563/#review19561
-----------------------------------------------------------


On Sept. 28, 2012, 8:30 p.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106563/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2012, 8:30 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> Currently, an empty tbcache file is created when the toolbar bookmarks are the full bookmarks, i.e. no entries/folders with toolbar attribute.  
> 
> 
> Diffs
> -----
> 
>   kio/bookmarks/kbookmarkmanager.cc d8a9cb7 
> 
> Diff: http://git.reviewboard.kde.org/r/106563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120929/c8a226f5/attachment.htm>


More information about the kde-core-devel mailing list