Review Request: Avoid creating an empty .tbcache for bookmarks

[Stefan Brüns]

> On Sept. 28, 2012, 5:32 p.m., David Faure wrote:
> > Why did the original code fail? It already checks for rootIsToolbarGroup(), which should be true in the case you describe, right? So the saving was supposed to be skipped then...

If a new bookmark file is created, no folder has the toolbar attribute, and the root folder is the implicit toolbar bookmark folder. The root folder can be set as toolbar bookmark folder, but this requires manual user action.

A different approach would be to require the toolbar attribute for at least one folder, this would also speed up findToolbar(). If this is preferred I can provide a new patch.


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106563/#review19523
-----------------------------------------------------------


On Sept. 25, 2012, 11:01 a.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106563/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2012, 11:01 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Currently, an empty tbcache file is created when the toolbar bookmarks are the full bookmarks, i.e. no entries/folders with toolbar attribute.  
> 
> 
> Diffs
> -----
> 
>   kio/bookmarks/kbookmarkmanager.cc d8a9cb7 
> 
> Diff: http://git.reviewboard.kde.org/r/106563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120928/b337f8f4/attachment.htm>