Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore
Dawit Alemayehu
adawit at kde.org
Fri Sep 28 17:46:39 BST 2012
> On Sept. 19, 2012, 9:28 p.m., Christoph Feck wrote:
> > Very nice. I think the text at the header could mention something along the line that you can choose which pages to restore.
Would a tooltip suffice ? See the new restore dialog v2 screenshot.
- Dawit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106503/#review19192
-----------------------------------------------------------
On Sept. 28, 2012, 4:45 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106503/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2012, 4:45 p.m.)
>
>
> Review request for KDE Base Apps and David Faure.
>
>
> Description
> -------
>
> The attached patch fixes one of those pet peeve bugs that infurate me from time to time by allowing me to unselect the sessions I do not want to be restored when Konqueror's restore session dialog pops up.
>
>
> This addresses bug 260282.
> http://bugs.kde.org/show_bug.cgi?id=260282
>
>
> Diffs
> -----
>
> konqueror/src/konqsessionmanager.h ee629e4
> konqueror/src/konqsessionmanager.cpp 68a003f
>
> Diff: http://git.reviewboard.kde.org/r/106503/diff/
>
>
> Testing
> -------
>
> * Unselected sessions should not be restored.
> * If all available sessions are selected (the default), the behavior should remain the same as it is today.
> * If all available sessions are unselected, disable the "Restore Session" button.
>
>
> Screenshots
> -----------
>
> old restore dialog
> http://git.reviewboard.kde.org/r/106503/s/729/
> new restore dialog
> http://git.reviewboard.kde.org/r/106503/s/731/
> new restore dialog v2
> http://git.reviewboard.kde.org/r/106503/s/739/
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120928/11741ebb/attachment.htm>
More information about the kde-core-devel
mailing list