Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106569/
-----------------------------------------------------------

(Updated Sept. 26, 2012, 12:53 p.m.)


Review request for Dolphin and KDE Base Apps.


Changes
-------

Moved the fix to KItemListView::event since it is the actual culprit.


Description
-------

This patch fixes a bug where pressing CTRL+Tab does not switch tabs when active tab in Konqueror is a Dolphin's filemanagement part. It happens because DolphinView installs an event filter and does not call event->ignore() or event->setAccepted(false) to allow those events to be propagated up the event chain.


This addresses bug 302329.
    http://bugs.kde.org/show_bug.cgi?id=302329


Diffs (updated)
-----

  dolphin/src/kitemviews/kitemlistview.cpp 54a8cbf 

Diff: http://git.reviewboard.kde.org/r/106569/diff/


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120926/6bf42d53/attachment.htm>