Review Request: Set noMerge=1 for menus when saving the xml file in kedittoolbar

David Faure faure at kde.org
Sun Sep 23 09:46:47 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106535/#review19350
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Sept. 22, 2012, 11:26 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106535/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2012, 11:26 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> As discussed with David add a noMerge=1 to xmlgui menus when saving them due to a edit toolbar action
> 
> 
> This addresses bug 306258.
>     http://bugs.kde.org/show_bug.cgi?id=306258
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kedittoolbar.cpp bb80952 
> 
> Diff: http://git.reviewboard.kde.org/r/106535/diff/
> 
> 
> Testing
> -------
> 
> Okular menus now don't get broken
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120923/3071245e/attachment.htm>


More information about the kde-core-devel mailing list