Review Request: Unbreak the build on Windows as there is no "uint" type recognized

Laszlo Papp lpapp at kde.org
Sun Sep 23 09:19:42 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106539/#review19349
-----------------------------------------------------------



kjs/jsonstringify.cpp
<http://git.reviewboard.kde.org/r/106539/#comment15300>

    We could also include "WinDef.h", but that would need ifdef'ing or finding a separate place where there is already a windows branching and alos appropriate for this.
    
    Since it only affects one line here as it seems so far, probably it is just better not to spare few characters here, but I do not mind either way. :-)


- Laszlo Papp


On Sept. 23, 2012, 8 a.m., Laszlo Papp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106539/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2012, 8 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> There may be another approaches for fixing this build issue I have not yet discovered, hence putting for review.
> 
> 
> Diffs
> -----
> 
>   kjs/jsonstringify.cpp f816e98 
> 
> Diff: http://git.reviewboard.kde.org/r/106539/diff/
> 
> 
> Testing
> -------
> 
> Build test
> 
> 
> Thanks,
> 
> Laszlo Papp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120923/42407914/attachment.htm>


More information about the kde-core-devel mailing list