Review Request: Fix compilation of Dolphin with future kdelibs, v4.9.2 or higher
Allen Winter
winter at kde.org
Sat Sep 15 14:51:58 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106438/#review18996
-----------------------------------------------------------
Ship it!
Builds with master, check
Builds with 4.9, check
thanks
- Allen Winter
On Sept. 13, 2012, 1:08 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106438/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2012, 1:08 p.m.)
>
>
> Review request for Dolphin and KDE Base Apps.
>
>
> Description
> -------
>
> Since this is not my call to make. The attached patch fixes the compilation of Dolphin with KDE v4.9.2. It is effectively a fix of a prior commit http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b which will not work. See http://lists.kde.org/?l=kde-core-devel&m=134747823101454&w=2.
>
>
> Diffs
> -----
>
> dolphin/src/CMakeLists.txt afc190f
> dolphin/src/dolphinpart.h 0895686
> dolphin/src/dolphinpart.cpp a7e8bff
> dolphin/src/dolphinpart_ext.h PRE-CREATION
> dolphin/src/dolphinpart_ext.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/106438/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120915/d49c1732/attachment.htm>
More information about the kde-core-devel
mailing list