Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

[Simeon Bird]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106242/
-----------------------------------------------------------

(Updated Sept. 9, 2012, 10:06 p.m.)


Review request for kdelibs and Plasma.


Changes
-------

v2: fix comments in review, and protect all variables, not just dict, so the whole spellchecker is thread-safe. 


Description
-------

Krunner's spellcheck plugin has been pretty broken since bd291d21f096a714a171e7af3a534ba345ca5659 (about two years ago) because it called Sonnet::Speller::setLanguage every time the spellchecker was invoked, which was (very much) not thread-safe.

This patch makes Sonnet::Speller::setLanguage threadsafe by protecting all access to the internal dict pointer using QReadWriteLock. 

A related review request is 106244, which adds more fixes to the spellcheck feature.


This addresses bugs 264779 and 303831.
    http://bugs.kde.org/show_bug.cgi?id=264779
    http://bugs.kde.org/show_bug.cgi?id=303831


Diffs (updated)
-----

  kdecore/sonnet/speller.cpp b19e74d 

Diff: http://git.reviewboard.kde.org/r/106242/diff/


Testing
-------

Compiled, installed, used for a week or so, spellchecked a bunch of things.


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120909/f076509c/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel