Review Request: Implementation of KParts listing filter extension for Dolphin

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106289/
-----------------------------------------------------------

(Updated Sept. 5, 2012, 1:28 p.m.)


Review request for Dolphin and KDE Base Apps.


Changes
-------

- Factored out the same exact code in setNameFilter and setMimeTypeFilters into a shared, applyFilters.
- Addressed the minor issues raised.


Description
-------

The attached patch provides an implementation of KParts' ListingFilterExtension for Dolphin. The extension allows the Dolphin KPart to provide directory/file filtering services without requiring direct linking against Dolphin itself.

The review for the new KPart listing filter extension (ListingFilterExtension) can be found at https://git.reviewboard.kde.org/r/106288/


Diffs (updated)
-----

  dolphin/src/views/dolphinview.h 10f63c5 
  dolphin/src/views/dolphinview.cpp 8050415 
  dolphin/src/kitemviews/private/kfileitemmodelfilter.cpp 816d356 
  dolphin/src/kitemviews/private/kfileitemmodelfilter.h 9bdf1fd 
  dolphin/src/dolphinpart.h e5693b3 
  dolphin/src/dolphinpart.cpp fff7dc0 
  dolphin/src/kitemviews/kfileitemmodel.h d9bebdf 
  dolphin/src/kitemviews/kfileitemmodel.cpp 6936af4 

Diff: http://git.reviewboard.kde.org/r/106289/diff/


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120905/75f4a872/attachment.htm>