Review Request: Move checks for locking primitives in KSharedDataCache to CMake

Michael Pyne mpyne at kde.org
Mon Sep 3 23:08:47 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106174/#review18473
-----------------------------------------------------------


I think I've figured out the issue with the missing files. The review request is indeed based against master, which isn't a big problem. If rebasing to KDE/4.10 will be an issue just let me know and I'll integrate the latest diff myself to KDE/4.10.

- Michael Pyne


On Aug. 27, 2012, 6:54 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106174/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2012, 6:54 p.m.)
> 
> 
> Review request for kdelibs and Michael Pyne.
> 
> 
> Description
> -------
> 
> This patch does move some run-time checks (mainly for different locking mechanisms) in KSharedDataCache to build time (CMake).
> 
> 
> This addresses bug 305023.
>     http://bugs.kde.org/show_bug.cgi?id=305023
> 
> 
> Diffs
> -----
> 
>   kdecore/util/ConfigureChecks.cmake fe9f47e 
>   kdecore/util/config-util.h.cmake 83ccdf7 
>   kdecore/util/kshareddatacache.cpp 393902e 
>   kdecore/util/kshareddatacache_p.h ec5a7a0 
> 
> Diff: http://git.reviewboard.kde.org/r/106174/diff/
> 
> 
> Testing
> -------
> 
> On OpenBSD-CURRENT.
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120903/b19a223b/attachment.htm>


More information about the kde-core-devel mailing list