Review Request: Hide empty additional information lines in icons view mode

[Todd Jennings]

> On Sept. 3, 2012, 11:46 a.m., Frank Reininghaus wrote:
> > Thanks, looks good from my point of view! I can't test it at the moment, but you can commit this the the 4.9 branch. There are a couple of weeks to go before 4.9.2 is tagged anyway, and I (and hopefully, more users of the 4.9 branch) will test it until then.

Are you sure backporting to 4.9 is safe?  This has a impacts on a lot of things besides just the icon view, it also impacts the other views, group headers, sorting, and perhaps other things as well.  I cannot personally guarantee there are no regressions or unexpected behavior. My personal inclination would be to hold off on this until 4.10, but of course you know the code much better than I do so I will backport if you think it is safe.  


> On Sept. 3, 2012, 11:46 a.m., Frank Reininghaus wrote:
> > dolphin/src/kitemviews/kstandarditemlistwidget.cpp, line 990
> > <http://git.reviewboard.kde.org/r/106304/diff/2/?file=82854#file82854line990>
> >
> >     Please remove the '\'.


- Todd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106304/#review18454
-----------------------------------------------------------


On Sept. 2, 2012, 10:41 a.m., Todd Jennings wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106304/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2012, 10:41 a.m.)
> 
> 
> Review request for Dolphin and KDE Base Apps.
> 
> 
> Description
> -------
> 
> Hide empty additional information lines in icons view mode.  Previously they were "-", which took up a lot of space while providing no additional information.
> 
> 
> This addresses bug 304752.
>     http://bugs.kde.org/show_bug.cgi?id=304752
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp 7ae7e2efcffc2f68c72a05cdbc3b29abc4c3aff4 
>   dolphin/src/kitemviews/private/knepomukrolesprovider.cpp 0ae9b6bd3edf88ea48c40bb491ef9e57148b8062 
> 
> Diff: http://git.reviewboard.kde.org/r/106304/diff/
> 
> 
> Testing
> -------
> 
> Tested and it works
> 
> 
> Thanks,
> 
> Todd Jennings
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120903/80520b3a/attachment.htm>