Review Request: Do not save window size from special (no toolbar) poup windows

[Dawit Alemayehu]

> On Aug. 3, 2012, 10:43 p.m., David Faure wrote:
> > How does this relate to the call to
> >      mainWindow->resetAutoSaveSettings(); // Don't autosave
> > in KonqMainWindow::slotCreateNewWindow? It's kind of the same idea. Well, in fact no, it's better ;)
> > 
> > You're only setting "save window size" to false, while "resetAutoSaveSettings" means "don't autosave anything, not even toolbar placement or anything".
> > 
> > I guess what this means is: if the new bool is only set in slotCreateNewWindow then the existing resetAutoSaveSettings is fine, otherwise it needs to be done elsewhere too.
> > The code in setProfileConfig is about loading the default settings (from the profile), but I guess there isn't much to load for "popup windows without toolbars" indeed. (e.g. if someone had the sidebar enabled in the profile, it should probably not show up in such windows). So maybe rather a if() in that method.

I saw the mainWindow->resetAutoSaveSettings() call too and thought that should prevent any information about the new window from being saved. Unfortunately that does not happen for some reason and the bug reported in 200907 can be readily reproduced. Perhaps something else overrides that setting later on. I guess I will have to further investigate this and solve it properly just like the location bar focus issue.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105841/#review16843
-----------------------------------------------------------


On Aug. 3, 2012, 9:02 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105841/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2012, 9:02 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> Now that the special window popup scenario has been dealt with, the attached one liner attempts to resolve the issue of the size of such poup windows being saved whenver "setAutoSaveSettings" is invoked.
> 
> 
> This addresses bug 200907.
>     http://bugs.kde.org/show_bug.cgi?id=200907
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqmainwindow.cpp 6faba58 
> 
> Diff: http://git.reviewboard.kde.org/r/105841/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120901/69fbcf86/attachment.htm>